Fix ROS build - #2571
Merged
Ratnesh Madaan (madratman) merged 2 commits intoApr 13, 2020
Merged
Conversation
…nly flags in if-else clause in commonsetup.cmake
Ratnesh Madaan (madratman)
force-pushed
the
PR/fix_ros_build
branch
from
April 13, 2020 16:43
b45c681 to
8962303
Compare
This was referenced Apr 13, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add libc++ with gcc in ros/cmakelists, move clang only flags in if-else clause in commonsetup.cmake
As highlighted in #2551, #2569, the ROS build is breaking.
This happened coz of #2500
The fix is to use libc++ with gcc, as explained here - https://libcxx.llvm.org/docs/UsingLibcxx.html#using-libc-with-gcc.